Talk:ISBN
This is the talk page for discussing improvements to the ISBN article. This is not a forum for general discussion of the article's subject. |
Article policies
|
Find sources: Google (books · news · scholar · free images · WP refs) · FENS · JSTOR · TWL |
Archives: Index, 1, 2, 3, 4, 5Auto-archiving period: 365 days |
This level-5 vital article is rated C-class on Wikipedia's content assessment scale. It is of interest to the following WikiProjects: | ||||||||||||||||||||||||||||||||||||||||||
|
On 16 April 2022, it was proposed that this article be moved from International Standard Book Number to ISBN. The result of the discussion was moved. |
This page has archives. Sections older than 365 days may be automatically archived by Lowercase sigmabot III when more than 4 sections are present. |
Semi-protected edit request on 21 November 2023
[edit]This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Change the establishment date from 1970 to 1967, as this is the more accurate date. My source is "https://www.archwaypublishing.com/en/faq/10-things-you-should-know-about-isbn" Guano islands (talk) 02:01, 21 November 2023 (UTC)
- Done Changed date and added reference. Lewcm Talk to me! 22:06, 21 November 2023 (UTC)
Semi-protected edit request on 29 January 2024
[edit]This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please remove these phrases:
will each have a different ISBN. will each have a different ISBN assigned to it.
and replace them with:
must each have a different ISBN. must each have a different ISBN assigned to it.
#1 is a lede summary dependent on #2, which relies on a source that says that each edition "shall be assigned" a different ISBN. Sometimes, publishers don't comply and don't assign separate ISBNs to different editions, so "will" is wrong, but "must" isn't affected by non-compliance. 123.51.107.94 (talk) 00:55, 29 January 2024 (UTC)
- Done I think "must" is better wording. In the document, "shall" is a pretty bad word for them to use as it can mean either "must" or "will" (thesaurus.com says they're synonyms.) Coulomb1 (talk) 02:15, 29 January 2024 (UTC)
checking for valid ISBN
[edit]Currently the article has a function `CheckISBN()` written in C that returns the error syndrome. However, it expects the input to be `int const digits[10]`, which is quite nonsensical and to the least impractical. Bytes would be more appropriate for digits -- where would you find an ISBN coded as array of ten 32-bit integers? It would be easy to allow to scan a string of bytes that might indifferently be UTF-8 or integer digits. I suggest the following code:
def CheckISBN(digits: Iterable) -> int: """Return ISBN error syndrome, zero for a valid ISBN, non-zero for an invalid one. Items in 'digits' that can't be cast to integer are ignored.""" c = t = s = u = 0 for d in digits: try: if c&1: u += int(d) # for 13-digit ISBN t += int(d); s += t; c += 1 except ValueError: pass # ignore non-digits like spaces, '-', ... if c == 10: return s % 11 if c != 13: raise ValueError(f"Expected 10 or 13 digits, got {c}.") return (t+2*u) % 10
If the C implementation is to be retained, one could use `t += digits[i] & 15` to convert ASCII digits to integers. As explained earlier, the argument should be `char digits[10]` to use bytes or characters rather than 32-bit integers. — MFH:Talk 17:31, 20 May 2024 (UTC)
- I disagree. That just obfuscates the straightforward algorithm. KISS principle ToraNeko (talk) ToraNeko (talk) 10:32, 31 May 2024 (UTC)
Semi-protected edit request on 9 September 2024
[edit]This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Mr Shakti raj}it suggests in this application software 2409:40E5:BB:AAD5:D842:FEFF:FE58:E11D (talk) 18:46, 9 September 2024 (UTC)
- Not done: it's not clear what changes you want to be made. Please mention the specific changes in a "change X to Y" format and provide a reliable source if appropriate. ⸺(Random)staplers 20:29, 9 September 2024 (UTC)
- C-Class level-5 vital articles
- Wikipedia level-5 vital articles in Technology
- C-Class vital articles in Technology
- C-Class Book articles
- WikiProject Books articles
- C-Class Libraries articles
- Low-importance Libraries articles
- WikiProject Libraries articles
- C-Class Retailing articles
- Mid-importance Retailing articles
- WikiProject Retailing articles